Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure Platform Logs: rename identity as identity_name when the value is a string #4629

Merged
merged 2 commits into from Nov 17, 2022
Merged

Azure Platform Logs: rename identity as identity_name when the value is a string #4629

merged 2 commits into from Nov 17, 2022

Conversation

zmoog
Copy link
Contributor

@zmoog zmoog commented Nov 11, 2022 •
edited

What does this PR do?

The identity field comes in different flavors, depending on the specific log category. It can be an object or a string.

If it comes as a string, the pipeline renames it as identity_name to avoid collisions when the value is an object.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@zmoog
Rename identity as identity_name when is a string
5d8c641 
The identity field comes in different flavours, depending on the
specific log category.

If it comes as a string, the pipeline renames it as identity_name to
avoid collisions when the value is an object.
@zmoog zmoog added bug Something isn't working Team:Cloud-Monitoring Label for the Cloud Monitoring team labels Nov 11, 2022
@zmoog zmoog self-assigned this Nov 11, 2022
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

elasticmachine commented Nov 11, 2022 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-16T16:23:05.584+0000

  • Duration: 15 min 40 sec

Test stats 🧪

Test Results
Failed 0
Passed 124
Skipped 0
Total 124

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Nov 11, 2022 •
edited

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (10/10) 💚
Files 86.364% (19/22) 👎 -11.322
Classes 86.364% (19/22) 👎 -11.322
Methods 83.422% (156/187) 👎 -7.847
Lines 85.038% (2785/3275) 👎 -6.667
Conditionals 100.0% (0/0) 💚

@zmoog zmoog changed the title Rename identity as identity_name when is a string Azure Platform Logs: rename identity as identity_name when is a string Nov 11, 2022
@zmoog zmoog changed the title Azure Platform Logs: rename identity as identity_name when is a string Azure Platform Logs: rename identity as identity_name when the value is a string Nov 11, 2022
@zmoog zmoog marked this pull request as ready for review November 16, 2022 12:50
@zmoog zmoog requested a review from a team as a code owner November 16, 2022 12:50
@zmoog zmoog merged commit af08bd7 into elastic:main Nov 17, 2022
@zmoog zmoog deleted the zmoog/identity-for-platform-logs branch November 17, 2022 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Assignees

@zmoog zmoog

Labels
bug Something isn't working Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Azure Logs] mapper_parsing_exception while parsing field [identity]
3 participants
@zmoog @elasticmachine @kaiyan-sheng