Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netflow,netscout,netskope,o365,okta: remove duplicate fields #4632

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Nov 14, 2022

What does this PR do?

This removes duplicate field definitions.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented Nov 14, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-14T05:38:38.774+0000

  • Duration: 16 min 19 sec

Test stats 🧪

Test Results
Failed 0
Passed 249
Skipped 0
Total 249

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🚀 Benchmarks report

Package netflow 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 41666.67 27777.78 -13888.89 (-33.33%) 💔

Package netscout 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
sightline 142857.14 35714.29 -107142.85 (-75%) 💔

Package netskope 👍(0) 💚(0) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
alerts 1923.08 1349.53 -573.55 (-29.82%) 💔
events 2624.67 1623.38 -1001.29 (-38.15%) 💔

Package o365 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
audit 2207.51 853.97 -1353.54 (-61.32%) 💔

Package okta 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
system 1356.85 673.4 -683.45 (-50.37%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (6/6) 💚
Files 100.0% (6/6) 💚 2.53
Classes 100.0% (6/6) 💚 2.53
Methods 97.403% (75/77) 👍 6.522
Lines 86.952% (1866/2146) 👎 -4.743
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review November 14, 2022 05:56
@efd6 efd6 requested a review from a team as a code owner November 14, 2022 05:56
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 merged commit 6a47c06 into elastic:main Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants