Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gcp] add compute pipeline test #4639

Merged
merged 3 commits into from
Nov 22, 2022

Conversation

gpop63
Copy link
Contributor

@gpop63 gpop63 commented Nov 14, 2022

What does this PR do?

Adds a test for the compute ingest pipeline.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@gpop63 gpop63 added Integration:GCP Team:Cloud-Monitoring Label for the Cloud Monitoring team labels Nov 14, 2022
@elasticmachine
Copy link

elasticmachine commented Nov 14, 2022

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

elasticmachine commented Nov 14, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-22T21:13:44.438+0000

  • Duration: 18 min 25 sec

Test stats 🧪

Test Results
Failed 0
Passed 53
Skipped 0
Total 53

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Nov 14, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (6/6) 💚
Files 100.0% (6/6) 💚
Classes 100.0% (6/6) 💚
Methods 90.291% (93/103) 👎 -7.37
Lines 95.976% (1455/1516) 👎 -0.987
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@tommyers-elastic tommyers-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding this gabriel. more tests ftw

@gpop63 gpop63 marked this pull request as ready for review November 22, 2022 21:32
@gpop63 gpop63 requested review from a team as code owners November 22, 2022 21:32
@gpop63 gpop63 merged commit 99dcdbe into elastic:main Nov 22, 2022
@elasticmachine
Copy link

Package gcp - 2.15.1 containing this change is available at https://epr.elastic.co

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:GCP Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants