Enabling kube-state metrics #4646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/kubernetes/changelog.yml
Outdated
| @@ -1,4 +1,9 @@ | |||
| # newer versions go on top | |||
| - version: "1.27.2" | |||
There was a problem hiding this comment.
shouldn't it be 1.28.0?
ChrsMark
reviewed
Nov 15, 2022
packages/kubernetes/changelog.yml
Outdated
| @@ -1,4 +1,9 @@ | |||
| # newer versions go on top | |||
| - version: "1.27.2" | |||
| changes: | |||
| - description: Enabling Kube-state Metrics by default | |||
There was a problem hiding this comment.
Just keep in mind that the reason of having this disabled is to avoid getting errors in case kube-state-metrics is not installed. Is we want to make this quite vocal then that's fine.
There was a problem hiding this comment.
updated with message for the banner :)
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
ChrsMark
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement
What does this PR do?
Enables Kube state metrics by default
Checklist
changelog.ymlfile.How to test this PR locally
Upgrade to 1.27.2 version and check if kube-state metrics is enabled by default
Related issues
Logs:
Filebeat and Metricbeat started successfully:
{"log.level":"info","@timestamp":"2022-11-15T09:54:20.257Z","log.origin":{"file.name":"stateresolver/stateresolver.go","file.line":49},"message":"Converging state requires execution of 3 step(s)","ecs.version":"1.6.0"} {"log.level":"info","@timestamp":"2022-11-15T09:54:21.170Z","log.origin":{"file.name":"log/reporter.go","file.line":40},"message":"2022-11-15T09:54:21Z - message: Application: metricbeat--8.5.0[1a9c4b03-c1ba-458e-9557-8abef159c34f]: State changed to RUNNING: Running - type: 'STATE' - sub_type: 'RUNNING'","ecs.version":"1.6.0"} {"log.level":"info","@timestamp":"2022-11-15T09:54:21.267Z","log.origin":{"file.name":"log/reporter.go","file.line":40},"message":"2022-11-15T09:54:21Z - message: Application: filebeat--8.5.0--36643631373035623733363936343635[1a9c4b03-c1ba-458e-9557-8abef159c34f]: State changed to RUNNING: Running - type: 'STATE' - sub_type: 'RUNNING'","ecs.version":"1.6.0"}When installed kube-state metrics, relevant dataset appeared: