Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] [Zscaler ZPA] Make enhancement in connector with best practices implementation #4648

Merged
merged 2 commits into from Nov 18, 2022

Conversation

vinit-chauhan
Copy link
Contributor

Type of change

  • Enhancement

What does this PR do?

Make enhancement in Zscaler ZPA connector with listed best practices.

Sr. No. Best Practices
1 Verify best practices test cases are executed
2 Verify all automated tests
3 Verify default values of port for TCP, UDP or HTTP Endpoint Input
4 Verify that the data is ingested in kibana for in interval
5 Verify all fields are correctly mapped for all Data streams
6 Verify related.ip field in datastream
7 Verify network.protocol is in lowercase form
8 Verify with invalid longitude range. [Valid Range : -180 to 180 for longitude]
9 Verify with invalid latitude range. [Valid Range: -90 to 90 for latitude]
10 Verify format of title of dashboard
11 Verify Datastream Dashboard
12 Verify filters in visualizations
13 Verify visualizations in different browser
14 Verify README file

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/zscaler_zpa directory.
  • Run the following command to run tests.

elastic-package test

Related issues

Screenshots

image
image
image

…r to the convert, geo_ip, uri_parts and date processors, and mapped to related ecs field
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

elasticmachine commented Nov 15, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-15T11:06:55.588+0000

  • Duration: 18 min 10 sec

Test stats 🧪

Test Results
Failed 0
Passed 30
Skipped 0
Total 30

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (5/5) 💚 2.542
Classes 100.0% (5/5) 💚 2.542
Methods 100.0% (59/59) 💚 9.137
Lines 90.175% (1542/1710) 👎 -1.449
Conditionals 100.0% (0/0) 💚

@P1llus P1llus merged commit 71c5255 into elastic:main Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants