Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fortinet_fortigate: add source and destination NAT IPs to related.ip #4658

Merged
merged 1 commit into from
Nov 16, 2022
Merged

fortinet_fortigate: add source and destination NAT IPs to related.ip #4658

merged 1 commit into from
Nov 16, 2022

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Nov 15, 2022

What does this PR do?

This adds the destination and source NAT IP addresses to related.ip and ensures that the source fields in the fortinet group are correctly ip typed.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added enhancement New feature or request Team:Security-External Integrations Integration:Fortinet (Deprecated) Use one of the specific fortinet_X labels. labels Nov 15, 2022
@efd6 efd6 self-assigned this Nov 15, 2022
@elasticmachine
Copy link

elasticmachine commented Nov 15, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-16T08:56:59.155+0000

  • Duration: 18 min 13 sec

Test stats 🧪

Test Results
Failed 0
Passed 9
Skipped 0
Total 9

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

elasticmachine commented Nov 16, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (4/4) 💚 2.53
Classes 100.0% (4/4) 💚 2.53
Methods 100.0% (38/38) 💚 9.101
Lines 92.289% (1113/1206) 👍 0.592
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review November 16, 2022 00:08
@efd6 efd6 requested a review from a team as a code owner November 16, 2022 00:08
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

kcreddy
kcreddy approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor change requested. Rest LGTM

packages/fortinet_fortigate/data_stream/log/elasticsearch/ingest_pipeline/traffic.yml Outdated Show resolved Hide resolved
@efd6 efd6 merged commit 0a9edf4 into elastic:main Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcreddy kcreddy kcreddy approved these changes

Assignees

@efd6 efd6

Labels
enhancement New feature or request Integration:Fortinet (Deprecated) Use one of the specific fortinet_X labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FORTIGATE] Related.ip does not contain the values of source.nat.ip and destination.nat.ip
3 participants
@efd6 @elasticmachine @kcreddy