Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken k8s Nodes dashboard for CSPs #4691

Merged
merged 2 commits into from
Nov 22, 2022

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Nov 22, 2022

What does this PR do?

Fixes #4537.
The issue exists for all k8s cluster that are not created with kubeadm. This means all cloud provider are affected.
Since the information of Control Plane column is not crucial we can completely remove it since it makes the whole panel to brake in many cases.

Screenshot

k8snodesCrappy

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark ChrsMark requested review from a team as code owners November 22, 2022 10:51
changes:
- description: Remove "Control Plane" column from Node Information table
type: enhancement
link: https://github.com/elastic/integrations/pull/9999
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@elasticmachine
Copy link

elasticmachine commented Nov 22, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-22T11:17:00.918+0000

  • Duration: 29 min 20 sec

Test stats 🧪

Test Results
Failed 0
Passed 91
Skipped 0
Total 91

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 94.872% (74/78)
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚

@ChrsMark ChrsMark merged commit 49f61bf into elastic:main Nov 22, 2022
@elasticmachine
Copy link

Package kubernetes - 1.29.0 containing this change is available at https://epr.elastic.co

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Kubernetes][Dashboards] Nodes Panel does not completely work for cloud providers
4 participants