Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure Blob Storage] Adding integration for Custom Azure Blob Storage Input #4693

Merged
merged 8 commits into from
Feb 7, 2023

Conversation

P1llus
Copy link
Member

@P1llus P1llus commented Nov 22, 2022

What does this PR do?

This adds support for using the custom Azure Blob Storage Input that was added to filebeat in 8.5.0.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@P1llus
Copy link
Member Author

P1llus commented Nov 22, 2022

Similar to #4692

There is currently a few questions up for discussion here:

  1. Will we add system tests, and how we should do it.
  2. Which ECS fields should we use, continuing a discussion around if we should include at least fields related to common metadata processors.
  3. Needs a new icon.

@P1llus P1llus requested a review from a team November 22, 2022 11:54
@elasticmachine
Copy link

elasticmachine commented Nov 22, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-07T08:53:37.581+0000

  • Duration: 14 min 4 sec

Test stats 🧪

Test Results
Failed 0
Passed 3
Skipped 0
Total 3

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@P1llus
Copy link
Member Author

P1llus commented Nov 22, 2022

Integration has not been fully tested yet, but will be soon (before merging)

@elasticmachine
Copy link

elasticmachine commented Nov 22, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 100.0% (3/3) 💚
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼
Once we have a way to run system tests, we could change to GA.

@botelastic
Copy link

botelastic bot commented Dec 31, 2022

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Dec 31, 2022
@narph
Copy link
Contributor

narph commented Jan 9, 2023

@P1llus , can we get this in?

@botelastic botelastic bot removed the Stalled label Jan 9, 2023
@P1llus
Copy link
Member Author

P1llus commented Jan 16, 2023

Was waiting for elastic/stream#47 to finalize and be merged, and wanted to wait for the dynamic ECS template functionality that was very recently merged here: elastic/elastic-package#1073 so that we could include this functionality from the initial version of the package.

@P1llus
Copy link
Member Author

P1llus commented Jan 19, 2023

All blocking features have now been resolved, will just have to update the PR with the system test and add dynamic ECS template before merging: #5055

@P1llus
Copy link
Member Author

P1llus commented Jan 23, 2023

This new input needs to be added to the filebeat spec file for elastic-agent first: https://github.com/elastic/elastic-agent/blob/main/specs/filebeat.spec.yml

@P1llus
Copy link
Member Author

P1llus commented Jan 23, 2023

Spec file updated as per: elastic/elastic-agent#2149
Awaiting new snapshot image to be generated.

Copy link
Contributor

@ShourieG ShourieG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor doc changes otherwise LGTM

P1llus and others added 2 commits February 7, 2023 09:52
Co-authored-by: ShourieG <105607378+ShourieG@users.noreply.github.com>
@P1llus P1llus merged commit 6a6d42b into elastic:main Feb 7, 2023
@elasticmachine
Copy link

Package azure_blob_storage - 0.1.0 containing this change is available at https://epr.elastic.co/search?package=azure_blob_storage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Azure Blob input package
5 participants