Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atlassian_{bitbucket,confluence,jira}: fix handling of zero-length event lists #4713

Merged
merged 1 commit into from
Nov 27, 2022

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Nov 23, 2022

What does this PR do?

This drops messages that have a zero-length event list for the atlassian packages.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented Nov 23, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-24T00:57:24.285+0000

  • Duration: 17 min 52 sec

Test stats 🧪

Test Results
Failed 0
Passed 29
Skipped 0
Total 29

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@efd6 efd6 marked this pull request as ready for review November 23, 2022 23:50
@efd6 efd6 requested a review from a team as a code owner November 23, 2022 23:50
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

elasticmachine commented Nov 24, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (7/7) 💚
Classes 100.0% (7/7) 💚
Methods 100.0% (62/62) 💚 75.0
Lines 98.778% (1212/1227) 👎 -1.222
Conditionals 100.0% (0/0) 💚

@efd6 efd6 merged commit 2398fa1 into elastic:main Nov 27, 2022
@elasticmachine
Copy link

Package atlassian_bitbucket - 1.5.1 containing this change is available at https://epr.elastic.co/search?package=atlassian_bitbucket

@elasticmachine
Copy link

Package atlassian_confluence - 1.6.1 containing this change is available at https://epr.elastic.co/search?package=atlassian_confluence

@elasticmachine
Copy link

Package atlassian_jira - 1.6.1 containing this change is available at https://epr.elastic.co/search?package=atlassian_jira

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

atlassian_*: packages do not gracefully handle messages with no event
3 participants