Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fortiedr: improve syslog set-up documentation #4744

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Dec 1, 2022

What does this PR do?

This clarifies the syslog notification setup process.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented Dec 1, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-12-01T00:14:05.759+0000

  • Duration: 15 min 21 sec

Test stats 🧪

Test Results
Failed 0
Passed 7
Skipped 0
Total 7

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 11.111
Classes 100.0% (1/1) 💚 11.111
Methods 100.0% (12/12) 💚 14.103
Lines 95.349% (205/215) 👍 0.22
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review December 1, 2022 01:05
@efd6 efd6 requested a review from a team as a code owner December 1, 2022 01:05
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6 efd6 merged commit 14194e9 into elastic:main Dec 1, 2022
@elasticmachine
Copy link

Package fortinet_fortiedr - 1.2.0 containing this change is available at https://epr.elastic.co/search?package=fortinet_fortiedr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants