Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

barracuda,bluecoat,cylance,f5,imperva,netscout,radware,squid: fix field docs #4802

Merged
merged 1 commit into from
Dec 14, 2022
Merged

barracuda,bluecoat,cylance,f5,imperva,netscout,radware,squid: fix field docs #4802

merged 1 commit into from
Dec 14, 2022

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Dec 12, 2022

What does this PR do?

This moves the README.md definition from the docs directory to the _dev/build/docs directory replacing the literal fields table with the replacement template and then builds each of the affected packages.

Packages that are deprecated were left alone.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 self-assigned this Dec 12, 2022
@elasticmachine
Copy link

elasticmachine commented Dec 12, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-12-14T08:27:29.691+0000

  • Duration: 18 min 59 sec

Test stats 🧪

Test Results
Failed 0
Passed 67
Skipped 3
Total 70

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Dec 12, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (9/9) 💚
Files 100.0% (9/9) 💚
Classes 100.0% (9/9) 💚
Methods 77.174% (71/92) 👎 -16.159
Lines 80.699% (439/544) 👎 -19.301
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review December 12, 2022 09:18
@efd6 efd6 requested a review from a team as a code owner December 12, 2022 09:18
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

kcreddy
kcreddy approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor clarification. LGTM 👍🏼

packages/infoblox/_dev/build/docs/README.md Outdated Show resolved Hide resolved
@efd6
barracuda,bluecoat,cylance,f5,imperva,netscout,radware,squid: fix fie…
41d150e 
…ld docs

This moves the README.md definition from the docs directory to the _dev/build/docs
directory replacing the literal fields table with the replacement template and then
builds each of the affected packages.

Packages that are deprecated were left alone.
@efd6 efd6 changed the title barracuda,bluecoat,cylance,f5,imperva,infoblox,netscout,radware,squid: fix field docs barracuda,bluecoat,cylance,f5,imperva,netscout,radware,squid: fix field docs Dec 14, 2022
@efd6 efd6 merged commit 1987ac4 into elastic:main Dec 14, 2022
@elasticmachine
Copy link

Package barracuda - 0.12.1 containing this change is available at https://epr.elastic.co/search?package=barracuda

@elasticmachine
Copy link

Package bluecoat - 0.11.1 containing this change is available at https://epr.elastic.co/search?package=bluecoat

@elasticmachine
Copy link

Package cylance - 0.11.1 containing this change is available at https://epr.elastic.co/search?package=cylance

@elasticmachine
Copy link

Package f5 - 0.12.1 containing this change is available at https://epr.elastic.co/search?package=f5

@elasticmachine
Copy link

Package imperva - 0.11.2 containing this change is available at https://epr.elastic.co/search?package=imperva

@elasticmachine
Copy link

Package netscout - 0.11.2 containing this change is available at https://epr.elastic.co/search?package=netscout

@elasticmachine
Copy link

Package radware - 0.10.2 containing this change is available at https://epr.elastic.co/search?package=radware

@elasticmachine
Copy link

Package squid - 0.11.2 containing this change is available at https://epr.elastic.co/search?package=squid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcreddy kcreddy kcreddy approved these changes

Assignees

@efd6 efd6

Labels
bug Something isn't working docs Integration:Barracuda Integration:Bluecoat Integration:Cylance Integration:F5 Integration:imperva Integration:Netscout Integration:Radware Integration:Squid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update README.md to rename process.ppid to process.parent.pid (Applies to ECS >=8.0)
3 participants
@efd6 @elasticmachine @kcreddy