Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

okta: handle already set event.original more robustly #4808

Merged
merged 2 commits into from
Dec 14, 2022

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Dec 13, 2022

What does this PR do?

This ensures that already-set event.original documents can still be ingested.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented Dec 13, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-12-14T09:07:09.997+0000

  • Duration: 14 min 56 sec

Test stats 🧪

Test Results
Failed 0
Passed 7
Skipped 0
Total 7

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Dec 13, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (17/17) 💚 6.667
Lines 86.111% (496/576) 👎 -13.889
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review December 13, 2022 01:00
@efd6 efd6 requested a review from a team as a code owner December 13, 2022 01:00
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor clarification. LGTM 👍🏼

@efd6 efd6 merged commit 969396c into elastic:main Dec 14, 2022
@elasticmachine
Copy link

Package okta - 1.12.0 containing this change is available at https://epr.elastic.co/search?package=okta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:Okta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Okta] Integration can throw the error field [event.original] already exists
3 participants