Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[m365_defender] Bugfix for when entities fields are empty #4865

Merged
merged 2 commits into from Dec 19, 2022

Conversation

P1llus
Copy link
Member

@P1llus P1llus commented Dec 19, 2022

What does this PR do?

When entities fields are empty, it will be returned as a List rather than a Map or even Null, this makes the painless conditions break, as it is expecting a Map.

This also fixed a small condition error for mapping event.category properly in certain situations.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

Copy link
Contributor

@ShourieG ShourieG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link

elasticmachine commented Dec 19, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-12-19T09:49:01.166+0000

  • Duration: 16 min 55 sec

Test stats 🧪

Test Results
Failed 0
Passed 15
Skipped 0
Total 15

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 96.667% (29/30) 👎 -3.333
Lines 94.447% (2296/2431) 👎 -1.958
Conditionals 100.0% (0/0) 💚

@P1llus P1llus merged commit b8e8203 into elastic:main Dec 19, 2022
@elasticmachine
Copy link

Package m365_defender - 1.4.2 containing this change is available at https://epr.elastic.co/search?package=m365_defender

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Integration: M365_Defender
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants