-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Golang] Add Integration Package with heap Data Stream #4908
Conversation
/test |
🌐 Coverage report
|
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
{{#if ssl}} | ||
request.ssl: {{ssl}} | ||
{{/if}} | ||
request.method: GET |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are both the GET and POST methods available for getting metrics?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, Both are available and provide the same result.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any performance difference between using the 2 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope. we get the same response from both methods.
Due to the limitation of integration package, following fields were dropped:
We have raised a github issue related to this limitation here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
…com/niraj-crest/integrations into package_golang_heap
…to package_golang_heap
What does this PR do?
Checklist
changelog.yml
file.How to test this PR locally
Related issues
Screenshots