Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RabbitMQ] Add support for new timestamp format #4918

Merged
merged 4 commits into from
Jan 31, 2023

Conversation

ritalwar
Copy link
Contributor

@ritalwar ritalwar commented Jan 3, 2023

  • Enhancement

What does this PR do?

This PR supports RabbitMQ new timestamp format with nanosecond precision and timezone "2022-03-23 13:16:58.000369+03:00".
Previous timestamp format "2019-04-12 10:11:15.094".
New DATETIME pattern is replaced by TIMESTAMP_ISO8601.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@elasticmachine
Copy link

elasticmachine commented Jan 3, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-24T12:48:54.673+0000

  • Duration: 13 min 7 sec

Test stats 🧪

Test Results
Failed 0
Passed 17
Skipped 0
Total 17

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jan 3, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 2.295
Classes 100.0% (1/1) 💚 2.295
Methods 70.0% (14/20) 👎 -21.454
Lines 73.913% (34/46) 👎 -18.967
Conditionals 100.0% (0/0) 💚

@ritalwar ritalwar marked this pull request as ready for review January 3, 2023 07:49
@ritalwar ritalwar requested a review from a team as a code owner January 3, 2023 07:49
@andrewkroh andrewkroh changed the title add support for new rabbitmq timestamp format [RabbitMQ] Add support for new timestamp format Jan 18, 2023
Copy link
Collaborator

@lalit-satapathy lalit-satapathy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ritalwar ritalwar merged commit 96d53d2 into elastic:main Jan 31, 2023
@elasticmachine
Copy link

Package rabbitmq - 1.5.0 containing this change is available at https://epr.elastic.co/search?package=rabbitmq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants