Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Posture] Update CSP mapping #4920

Merged
merged 2 commits into from
Jan 3, 2023
Merged

[Cloud Posture] Update CSP mapping #4920

merged 2 commits into from
Jan 3, 2023

Conversation

oren-zohar
Copy link
Contributor

@oren-zohar oren-zohar commented Jan 3, 2023

What does this PR do?

Update mapping of newly introduced fields in cloudbeat's output

Related issues

Screenshots

Relevant fields:
image

@oren-zohar oren-zohar requested a review from a team as a code owner January 3, 2023 09:22
Copy link
Contributor

@eyalkraft eyalkraft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also document in the technical index

type: date
description: The commit time of the Cloudbeat.
default_field: false
- name: kubernetes.version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that might fit better into orchestrator.cluster.version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eyalkraft honestly I'm not sure why we abandoned that, maybe we should have added it to that field. In any case, we have a separate task for it. @kfirpeled perhaps you have more information?

@elasticmachine
Copy link

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-03T09:22:19.370+0000

  • Duration: 14 min 38 sec

Test stats 🧪

Test Results
Failed 0
Passed 2
Skipped 0
Total 2

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 25.0% (1/4) 👎 -63.889
Lines 100.0% (0/0) 💚 9.596
Conditionals 100.0% (0/0) 💚

@oren-zohar oren-zohar merged commit d203753 into main Jan 3, 2023
@oren-zohar oren-zohar deleted the updade-csp-mapping branch January 3, 2023 09:41
@elasticmachine
Copy link

Package cloud_security_posture - 1.2.1 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@kfirpeled kfirpeled added the Team:Cloud Security Label for the Cloud Security team label Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Cloud Security Label for the Cloud Security team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update version info mapping in the integration
4 participants