New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Windows] Added support for custom processors on perfmon #4956
Conversation
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There needs to be a change to the config file to utilize these processors you added to the manfiest.
perfmon/agent/stream/stream.yml.hbs:
{{#if processors}}
processors:
{{processors}}
{{/if}}
@andrewkroh somehow I am still missing something? |
packages/windows/changelog.yml
Outdated
@@ -1,4 +1,9 @@ | |||
# newer versions go on top | |||
- version: "1.15.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version contained in the windows/manifest.yml
needs updated to 1.15.3. CI is complaining about:
[2023-01-19T12:54:34.746Z] Error: checking package failed: linting package failed: found 1 validation error:
[2023-01-19T12:54:34.746Z] 1. current manifest version doesn't have changelog entry
I would say this is a new feature rather than a bug fix so using 1.16.0 would be more appropriate under semver.org rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would love to know what I did wrong. I added 1.15.3 back then and now changed it to 1.16, but it still error with:
[2023-01-20T09:31:58.481Z] Error: checking package failed: linting package failed: found 1 validation error:
[2023-01-20T09:31:58.481Z] 1. current manifest version doesn't have changelog entry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's a check the verifies that the latest changelog entry matches the version
contained in the manefest.yml. So until those two values are the same we will get this type of error.
🌐 Coverage report
|
@elastic/elastic-agent-data-plane As the package owner, are you good with these changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Package windows - 1.16.0 containing this change is available at https://epr.elastic.co/search?package=windows |
What does this PR do?
Adds support for the custom processor definition in windows perfmon.
Checklist
changelog.yml
file.