Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Added support for custom processors on perfmon #4956

Merged
merged 6 commits into from Jan 25, 2023

Conversation

philippkahr
Copy link
Contributor

@philippkahr philippkahr commented Jan 10, 2023

What does this PR do?

Adds support for the custom processor definition in windows perfmon.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have added an entry to my package's changelog.yml file.

@philippkahr philippkahr added the enhancement New feature or request label Jan 10, 2023
@philippkahr philippkahr requested review from a team as code owners January 10, 2023 10:13
@elasticmachine
Copy link

elasticmachine commented Jan 10, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-23T19:49:28.853+0000

  • Duration: 16 min 27 sec

Test stats 🧪

Test Results
Failed 0
Passed 129
Skipped 0
Total 129

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@cmacknz cmacknz added the Team:Elastic-Agent Label for the Agent team label Jan 10, 2023
@elasticmachine
Copy link

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@andrewkroh andrewkroh changed the title Added support for custom processors on windows perfmon. [Windows] Added support for custom processors on perfmon Jan 18, 2023
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There needs to be a change to the config file to utilize these processors you added to the manfiest.

perfmon/agent/stream/stream.yml.hbs:

{{#if processors}}
processors:
{{processors}}
{{/if}}

@philippkahr
Copy link
Contributor Author

@andrewkroh somehow I am still missing something?

@@ -1,4 +1,9 @@
# newer versions go on top
- version: "1.15.3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version contained in the windows/manifest.yml needs updated to 1.15.3. CI is complaining about:

[2023-01-19T12:54:34.746Z] Error: checking package failed: linting package failed: found 1 validation error:

[2023-01-19T12:54:34.746Z]    1. current manifest version doesn't have changelog entry

I would say this is a new feature rather than a bug fix so using 1.16.0 would be more appropriate under semver.org rules.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would love to know what I did wrong. I added 1.15.3 back then and now changed it to 1.16, but it still error with:

[2023-01-20T09:31:58.481Z] Error: checking package failed: linting package failed: found 1 validation error:
[2023-01-20T09:31:58.481Z]    1. current manifest version doesn't have changelog entry

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a check the verifies that the latest changelog entry matches the version contained in the manefest.yml. So until those two values are the same we will get this type of error.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 87.5% (7/8) 👎 -12.5
Classes 87.5% (7/8) 👎 -12.5
Methods 83.516% (76/91) 👎 -16.484
Lines 92.714% (5039/5435) 👍 10.559
Conditionals 100.0% (0/0) 💚

@andrewkroh
Copy link
Member

@elastic/elastic-agent-data-plane As the package owner, are you good with these changes?

Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewkroh andrewkroh merged commit 4517017 into main Jan 25, 2023
@elasticmachine
Copy link

Package windows - 1.16.0 containing this change is available at https://epr.elastic.co/search?package=windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:Windows Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants