Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cisco ASA] Interchange source, destination for messages 302013 & 302015 #5004

Merged
merged 4 commits into from
Jan 23, 2023

Conversation

kcreddy
Copy link
Contributor

@kcreddy kcreddy commented Jan 16, 2023

What does this PR do?

As per Cisco doc for messages 302013 & 302015, whenever outbound is specified in the network.direction, the original control connection was initiated from the inside. This interchanges current the source and destination parsing.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@kcreddy kcreddy self-assigned this Jan 16, 2023
@kcreddy kcreddy added Integration:CiscoASA Cisco ASA bug Something isn't working labels Jan 16, 2023
@elasticmachine
Copy link

elasticmachine commented Jan 16, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-16T12:14:56.326+0000

  • Duration: 17 min 28 sec

Test stats 🧪

Test Results
Failed 0
Passed 23
Skipped 0
Total 23

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jan 16, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 2.509
Classes 100.0% (1/1) 💚 2.509
Methods 100.0% (18/18) 💚 8.302
Lines 83.721% (1584/1892) 👎 -7.647
Conditionals 100.0% (0/0) 💚

@kcreddy kcreddy marked this pull request as ready for review January 18, 2023 07:53
@kcreddy kcreddy requested a review from a team as a code owner January 18, 2023 07:53
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@andrewkroh andrewkroh changed the title Cisco ASA | Interchange source, destination for messages 302013 & 302015 [Cisco ASA] Interchange source, destination for messages 302013 & 302015 Jan 18, 2023
@kcreddy kcreddy merged commit c669536 into elastic:main Jan 23, 2023
@elasticmachine
Copy link

Package cisco_asa - 2.12.1 containing this change is available at https://epr.elastic.co/search?package=cisco_asa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Integration:CiscoASA Cisco ASA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Cisco ASA] Source and destination fields interchanged
3 participants