Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimecast: fingerprint audit events based on their event ID #5018

Merged
merged 1 commit into from Jan 17, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jan 16, 2023

What does this PR do?

This fingerprints audit event documents based on their event ID to prevent duplicate document ingestion.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented Jan 16, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-16T23:22:14.737+0000

  • Duration: 20 min 31 sec

Test stats 🧪

Test Results
Failed 0
Passed 56
Skipped 0
Total 56

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (8/8) 💚
Files 100.0% (8/8) 💚
Classes 100.0% (8/8) 💚
Methods 92.308% (108/117)
Lines 87.994% (1224/1391)
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review January 16, 2023 23:42
@efd6 efd6 requested a review from a team as a code owner January 16, 2023 23:42
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 merged commit eb35ba9 into elastic:main Jan 17, 2023
@elasticmachine
Copy link

Package mimecast - 1.6.0 containing this change is available at https://epr.elastic.co/search?package=mimecast

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:Mimecast Mimecast integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Mimecast] Duplicate events
3 participants