Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCP] Remove broken input control reference panel and replace with new-style control #5032

Merged

Conversation

tommyers-elastic
Copy link
Contributor

@tommyers-elastic tommyers-elastic commented Jan 18, 2023

What does this PR do?

Before:

Screenshot 2023-01-18 at 10 01 57

After:

Screenshot 2023-01-18 at 10 02 17

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • Install the dashboard locally to validate the new controls.

How to test this PR locally

cd packages/gcp
elastic-package build .
elastic-package stack up -d --services=package-registry
...

Related issues

@elasticmachine
Copy link

elasticmachine commented Jan 18, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-19T14:21:39.782+0000

  • Duration: 19 min 51 sec

Test stats 🧪

Test Results
Failed 0
Passed 53
Skipped 0
Total 53

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jan 18, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (6/6) 💚
Files 100.0% (6/6) 💚
Classes 100.0% (6/6) 💚
Methods 90.291% (93/103) 👍 29.532
Lines 95.976% (1455/1516) 👎 -2.817
Conditionals 100.0% (0/0) 💚

@andrewkroh andrewkroh changed the title Remove broken input control reference panel and replace with new-style control [GCP] Remove broken input control reference panel and replace with new-style control Jan 18, 2023
@tommyers-elastic tommyers-elastic merged commit 570e86f into elastic:main Jan 30, 2023
@elasticmachine
Copy link

Package gcp - 2.16.1 containing this change is available at https://epr.elastic.co/search?package=gcp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard [Metrics GCP] Compute Overview - missing visualization
4 participants