Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O365] Add fingerprint processor to prevent ingestion of duplicate events #5047

Merged
merged 3 commits into from
Jan 23, 2023

Conversation

taylor-swanson
Copy link
Contributor

@taylor-swanson taylor-swanson commented Jan 18, 2023

What does this PR do?

  • Added a fingerprint processor to prevent duplicate events from being ingested. It generates a hash based on the o365audit field.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

…gested

- Added a fingerprint processor to prevent duplicate events from
being ingested. It generates a hash based on the o365audit field.
@elasticmachine
Copy link

elasticmachine commented Jan 18, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-23T14:12:59.337+0000

  • Duration: 15 min 10 sec

Test stats 🧪

Test Results
Failed 0
Passed 24
Skipped 0
Total 24

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (16/16) 💚
Lines 82.155% (732/891)
Conditionals 100.0% (0/0) 💚

@taylor-swanson taylor-swanson marked this pull request as ready for review January 18, 2023 18:06
@taylor-swanson taylor-swanson requested a review from a team as a code owner January 18, 2023 18:06
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@@ -14,6 +14,11 @@ processors:
- append:
field: event.category
value: web
- fingerprint:
fields:
- o365audit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could potentially be o365audit.ObjectId or o365audit.Id for a cheaper fingerprint. (The latter matches the @metadata._id that I see in logs).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. For performance reasons, I think I'll go ahead and switch it to that.

@taylor-swanson taylor-swanson merged commit 4d554d3 into elastic:main Jan 23, 2023
@taylor-swanson taylor-swanson deleted the 5046-o365-fingerprint branch January 23, 2023 14:31
@elasticmachine
Copy link

Package o365 - 1.10.1 containing this change is available at https://epr.elastic.co/search?package=o365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:o365 Microsoft Office 365
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[O365] Add fingerprint processor to prevent duplicate events being ingested
3 participants