-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Azure Logs] Fix authentication_processing_details parsing in sign-in logs #5129
Merged
zmoog
merged 3 commits into
elastic:main
from
zmoog:zmoog/azure-authentication-processing-details-issue
Feb 7, 2023
Merged
[Azure Logs] Fix authentication_processing_details parsing in sign-in logs #5129
zmoog
merged 3 commits into
elastic:main
from
zmoog:zmoog/azure-authentication-processing-details-issue
Feb 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🌐 Coverage report
|
andrewkroh
reviewed
Jan 27, 2023
packages/azure/data_stream/signinlogs/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
If ready, let’s move forward with this |
andrewkroh
approved these changes
Feb 6, 2023
endorama
approved these changes
Feb 7, 2023
Turns the `authentication_processing_details` array elements into key/value pairs without creating sub-fields if the key contains one or more dots. For example, the array element: `{"key": "TLS 1.0", "value": False}` Becomes: `{"TLS 1.0": "False"}` Previously the `set` processor would have created an unintended sub field: `{"TLS 1": {".0": "False"}}` I know it's weird having dots in the keys, but it's the way it is.
…eline/default.yml Thank you @andrewkroh! Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
cd68425
to
aeaf106
Compare
Package azure - 1.5.7 containing this change is available at https://epr.elastic.co/search?package=azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What
Replace the
foreach
+set
processors combo with a singlescript
processor in the ingest pipeline for Azure AD sign-in logs.Why
The
set
processor expands the dots contained in the field name into subfields.Sometimes attributes contained in
authentication_processing_details
have dots, for example:In such cases, the
set
processor would turn it into:Instead of:
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots