Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IIS] Accept multiple application_pool name #5140

Merged
merged 2 commits into from
Jan 31, 2023

Conversation

muthu-mps
Copy link
Contributor

@muthu-mps muthu-mps commented Jan 30, 2023

  • Bug

What does this PR do?

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.

How to test this PR locally

Create multiple application pools in IIS Manager
Verify all the application pool metrics are getting captured.
Specify names in the application pool configuration and verify whether only those metrics are being captured.

Related issues

Screenshots

@muthu-mps muthu-mps self-assigned this Jan 30, 2023
@muthu-mps muthu-mps marked this pull request as ready for review January 30, 2023 07:21
@muthu-mps muthu-mps requested a review from a team as a code owner January 30, 2023 07:21
@elasticmachine
Copy link

elasticmachine commented Jan 30, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-30T07:20:42.152+0000

  • Duration: 13 min 10 sec

Test stats 🧪

Test Results
Failed 0
Passed 29
Skipped 0
Total 29

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 85.714% (30/35) 👎 -2.475
Lines 93.772% (271/289) 👎 -3.887
Conditionals 100.0% (0/0) 💚

@ishleenk17
Copy link
Contributor

Changes look fine. Do we have some test data for this? and sample event generated for the same.

@muthu-mps
Copy link
Contributor Author

Each application pool comes as a separate document. This change will get reflected in Kibana. I am adding the screenshot here for reference.
image

Copy link
Contributor

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@muthu-mps muthu-mps merged commit ee6ef8d into elastic:main Jan 31, 2023
@elasticmachine
Copy link

Package iis - 1.4.1 containing this change is available at https://epr.elastic.co/search?package=iis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IIS - Multiple application pool names metrics are not getting processed
3 participants