Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

o365: retain file, directory and URL details for SharePointSharingOperation #5146

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jan 30, 2023

What does this PR do?

Adds "SharePointSharingOperation" to event codes that have file, directory and URL details retained in ECS fields.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented Jan 30, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-01T00:20:24.438+0000

  • Duration: 15 min 33 sec

Test stats 🧪

Test Results
Failed 0
Passed 24
Skipped 0
Total 24

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jan 30, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (16/16) 💚 33.333
Lines 82.155% (732/891) 👎 -17.845
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review January 30, 2023 23:53
@efd6 efd6 requested a review from a team as a code owner January 30, 2023 23:53
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM 👍🏼
Just need clarification if file.directory and url.original should also be set?

@efd6
Copy link
Contributor Author

efd6 commented Jan 31, 2023

Those look reasonably straightforward at first sight. I'll check if they make sense generally.

@efd6 efd6 changed the title o365: retain file details for SharePointSharingOperation o365: retain file, directory and URL details for SharePointSharingOperation Feb 1, 2023
@efd6 efd6 merged commit 101a8a3 into elastic:main Feb 1, 2023
@elasticmachine
Copy link

Package o365 - 1.11.0 containing this change is available at https://epr.elastic.co/search?package=o365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:o365
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[O365] Audit Integration - Missing ecs fields file.name and file.extension
3 participants