Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sophos_central] Initial Release for the Sophos Central #5195

Merged
merged 4 commits into from
Feb 20, 2023

Conversation

brijesh-elastic
Copy link
Contributor

What does this PR do?

  • Generated the skeleton of the Sophos Central integration package.
  • Added data streams.
  • Added data collection logic for all the data streams.
  • Added the ingest pipeline for all the data streams.
  • Mapped fields according to the ECS schema and added Fields metadata in the appropriate yml files.
  • Added dashboards and visualizations.
  • Added test for pipeline for all the data streams.
  • Added system test cases for all the data streams.

Integration release checklist

This checklist is intended for integrations maintainers to ensure consistency
when creating or updating a Package, Module or Dataset for an Integration.

All changes

  • Change follows the contributing guidelines
  • Supported versions of the monitoring target is documented
  • Supported operating systems are documented (if applicable)
  • Integration or System tests exist
  • Documentation exists
  • Fields follow ECS and naming conventions
  • At least a manual test with ES / Kibana / Agent has been performed.
  • Required Kibana version set to: ^7.17.0 || ^8.0.0

New Package

  • Screenshot of the "Add Integration" page on Fleet added

Dashboards changes

  • Dashboards exists
  • Screenshots added or updated
  • Datastream filters added to visualizations

Log dataset changes

  • Pipeline tests exist (if applicable)
  • Generated output for at least 1 log file exists
  • Sample event (sample_event.json) exists

How to test this PR locally

  • Clone integrations repo.
  • Install elastic package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/sophos_central directory.
  • Run the following command to run tests.

elastic-package test

Related issues

Screenshots

image
image
image
image
image
image

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Feb 7, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-17T14:00:18.804+0000

  • Duration: 16 min 8 sec

Test stats 🧪

Test Results
Failed 0
Passed 12
Skipped 0
Total 12

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@vinit-chauhan
Copy link
Contributor

/test

@elasticmachine
Copy link

elasticmachine commented Feb 7, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚 15.385
Classes 100.0% (2/2) 💚 15.385
Methods 94.118% (32/34) 👍 2.337
Lines 93.491% (991/1060) 👍 8.346
Conditionals 100.0% (0/0) 💚

@vinit-chauhan
Copy link
Contributor

/test

@P1llus
Copy link
Member

P1llus commented Feb 14, 2023

As discussed on the weekly meeting, feel free to add the dynamic template as well, according to: #5055

@vinit-chauhan
Copy link
Contributor

/test

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@P1llus P1llus merged commit f68d2b9 into elastic:main Feb 20, 2023
@elasticmachine
Copy link

Package sophos_central - 0.1.0 containing this change is available at https://epr.elastic.co/search?package=sophos_central

agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 20, 2023
* Initial Release for the Sophos Central

* Update the changelog entry

* Resolved review comments

* Add dynamic mapping
agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 21, 2023
* Initial Release for the Sophos Central

* Update the changelog entry

* Resolved review comments

* Add dynamic mapping
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request New Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sophos Central
5 participants