Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assign streams to inputs #5267

Merged
merged 3 commits into from
Feb 14, 2023
Merged

Assign streams to inputs #5267

merged 3 commits into from
Feb 14, 2023

Conversation

jeniawhite
Copy link
Contributor

@jeniawhite jeniawhite commented Feb 14, 2023 •
edited
Loading

What does this PR do?

GCP and Azure inputs weren't mapped to any stream.
This caused the fleet to crash due to it being unable to find stream.yml.hbs that it assigns by default in such cases.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@jeniawhite jeniawhite added the bug Something isn't working label Feb 14, 2023
@jeniawhite jeniawhite requested a review from a team as a code owner February 14, 2023 10:35
@jeniawhite jeniawhite self-assigned this Feb 14, 2023
oren-zohar
oren-zohar approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@oren-zohar oren-zohar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link

elasticmachine commented Feb 14, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-14T11:57:31.986+0000

  • Duration: 14 min 0 sec

Test stats 🧪

Test Results
Failed 0
Passed 2
Skipped 0
Total 2

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@jeniawhite
Copy link
Contributor Author

/test

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 3.476
Classes 100.0% (0/0) 💚 3.476
Methods 25.0% (1/4) 👎 -66.062
Lines 100.0% (0/0) 💚 8.61
Conditionals 100.0% (0/0) 💚

@jeniawhite jeniawhite mentioned this pull request Feb 14, 2023
Closed
@jeniawhite jeniawhite merged commit 618b9fa into elastic:main Feb 14, 2023
@elasticmachine
Copy link

Package cloud_security_posture - 1.2.10-beta2 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@kpollich kpollich mentioned this pull request Jan 29, 2024
Open
bhapas pushed a commit to bhapas/integrations that referenced this pull request Feb 16, 2023
@jeniawhite @bhapas
Assign streams to inputs (elastic#5267)
839a424 
* Assign streams to inputs

* Add changelog

* Rename type to bugfix
@kfirpeled kfirpeled added the Team:Cloud Security Label for the Cloud Security team label Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oren-zohar oren-zohar oren-zohar approved these changes

Assignees

@jeniawhite jeniawhite

Labels
bug Something isn't working Team:Cloud Security Label for the Cloud Security team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Cloud Security] Fleet server breaks upon upgrade from 8.6 to 8.7 with existing KSPM integration
4 participants
@jeniawhite @elasticmachine @oren-zohar @kfirpeled