Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ IIS ] - Replace deprecated control filter with new control #5306

Merged
merged 2 commits into from
Mar 6, 2023

Conversation

muthu-mps
Copy link
Contributor

@muthu-mps muthu-mps commented Feb 16, 2023

  • Enhancement

What does this PR do?

Replaces the older deprecated control filter with new control panel. The old filter doesn't respect the selected time range in Kibana to load the data.

The Kibana version has been updated to 8.3.0 as the new control panel is introduced in 8.3.0

Checklist

  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Verify the control filter is replaced with the new one.
Check the dashboards loading data.

Related issues

@elasticmachine
Copy link

elasticmachine commented Feb 16, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-16T13:56:39.293+0000

  • Duration: 14 min 4 sec

Test stats 🧪

Test Results
Failed 0
Passed 29
Skipped 0
Total 29

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 85.714% (30/35) 👎 -14.286
Lines 93.772% (271/289) 👎 -0.086
Conditionals 100.0% (0/0) 💚

@muthu-mps muthu-mps marked this pull request as ready for review February 16, 2023 14:21
@muthu-mps muthu-mps requested a review from a team as a code owner February 16, 2023 14:21
@muthu-mps muthu-mps self-assigned this Feb 16, 2023
@@ -38,7 +38,8 @@
},
"type": "markdown",
"uiState": {}
}
},
"type": "visualization"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this required as part of this change ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the type is missing then the export-dashboard command adds automatically.

@muthu-mps muthu-mps merged commit df323e8 into elastic:main Mar 6, 2023
@elasticmachine
Copy link

Package iis - 1.5.0 containing this change is available at https://epr.elastic.co/search?package=iis

agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 20, 2023
…#5306)

* Update deprecated control option

* updated changelog entry
agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 21, 2023
…#5306)

* Update deprecated control option

* updated changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IIS Application pool datastream with outdated Filter
3 participants