Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[o365] Update fields.yml with new ListBaseType field #5314

Merged
merged 4 commits into from
Mar 2, 2023
Merged

[o365] Update fields.yml with new ListBaseType field #5314

merged 4 commits into from
Mar 2, 2023

Conversation

nicpenning
Copy link
Contributor

Please label this PR with one of the following labels, depending on the scope of your change:

  • Enhancement

What does this PR do?

This PR adds the new o365.audit.ListBaseType that could be categorized as a long on a rollover or new index creation. Previously this was a keyword but could be mapped to a long which does not fit since the value could be either null, 1, 2, or some small integer.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@nicpenning nicpenning requested a review from a team as a code owner February 17, 2023 18:01
@elasticmachine
Copy link

elasticmachine commented Feb 17, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-23T08:03:03.302+0000

  • Duration: 14 min 21 sec

Test stats 🧪

Test Results
Failed 0
Passed 24
Skipped 0
Total 24

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@ShourieG
Copy link
Contributor

/test

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 3.432
Classes 100.0% (1/1) 💚 3.432
Methods 100.0% (16/16) 💚 8.848
Lines 82.155% (732/891) 👎 -9.253
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@ShourieG ShourieG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@P1llus P1llus merged commit 67d4838 into elastic:main Mar 2, 2023
@elasticmachine
Copy link

Package o365 - 1.13.0 containing this change is available at https://epr.elastic.co/search?package=o365

@nicpenning nicpenning deleted the patch-2 branch March 2, 2023 12:07
agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 20, 2023
* Update fields.yml

* Update changelog.yml

* Update manifest.yml

* Update README.md
agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 21, 2023
* Update fields.yml

* Update changelog.yml

* Update manifest.yml

* Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants