Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network_traffic: fix type of real_ip_header option for HTTP data stream #5362

Merged
merged 1 commit into from Feb 23, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Feb 23, 2023

What does this PR do?

Fixes type of real_ip_header option for HTTP data stream.

The backing configuration expects a string, not a bool.

https://github.com/elastic/beats/blob/1f1868d6b1c98d9b9b995e6ffbb3772b8ee293b1/packetbeat/protos/http/config.go#L31

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Screenshot 2023-02-23 at 12 43 25

@elasticmachine
Copy link

elasticmachine commented Feb 23, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-23T03:59:49.162+0000

  • Duration: 70 min 23 sec

Test stats 🧪

Test Results
Failed 0
Passed 173
Skipped 0
Total 173

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Feb 23, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 3.432
Classes 100.0% (0/0) 💚 3.432
Methods 71.875% (46/64) 👎 -19.277
Lines 100.0% (0/0) 💚 8.592
Conditionals 100.0% (0/0) 💚

@efd6
Copy link
Contributor Author

efd6 commented Feb 23, 2023

/test

@efd6 efd6 marked this pull request as ready for review February 23, 2023 05:52
@efd6 efd6 requested a review from a team as a code owner February 23, 2023 05:52
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 merged commit 01131cd into elastic:main Feb 23, 2023
@elasticmachine
Copy link

Package network_traffic - 1.9.1 containing this change is available at https://epr.elastic.co/search?package=network_traffic

agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 20, 2023
agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants