Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[windows] Update event code in powershell_operational ingest pipeline processor description #5383

Merged
merged 8 commits into from
Mar 30, 2023

Conversation

Doserdog
Copy link
Contributor

@Doserdog Doserdog commented Feb 24, 2023

  • Bug

What does this PR do?

Updates ingest pipeline processor description with correct event code.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Screenshots

image

@cla-checker-service
Copy link

cla-checker-service bot commented Feb 24, 2023

💚 CLA has been signed

@elasticmachine
Copy link

elasticmachine commented Feb 24, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-15T22:29:40.073+0000

  • Duration: 17 min 20 sec

Test stats 🧪

Test Results
Failed 0
Passed 129
Skipped 0
Total 129

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@Doserdog
Copy link
Contributor Author

/test

@efd6
Copy link
Contributor

efd6 commented Feb 26, 2023

/test

@elasticmachine
Copy link

elasticmachine commented Feb 26, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 87.5% (7/8) 👎 -12.5
Classes 87.5% (7/8) 👎 -12.5
Methods 83.516% (76/91) 👎 -16.484
Lines 92.748% (5103/5502) 👍 2.527
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@nicpenning nicpenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will likely need to bump this up to 1.18.1 due to a feature that was recently merged. #5384

Copy link
Contributor

@nicpenning nicpenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to update here as well.

@Doserdog
Copy link
Contributor Author

Doserdog commented Mar 9, 2023

/test

@nicpenning
Copy link
Contributor

You still need to update the changelog and manifest. :)

@Doserdog
Copy link
Contributor Author

Thanks!

/test

@efd6
Copy link
Contributor

efd6 commented Mar 13, 2023

/test

@nicpenning
Copy link
Contributor

Looks like another System integration was updated and commited to pass this again. You will probably need to update the version again :( Is there a better way to handle this?

#5511

@efd6
Copy link
Contributor

efd6 commented Mar 15, 2023

/test

@efd6 efd6 merged commit 2bcab80 into elastic:main Mar 30, 2023
@elasticmachine
Copy link

Package windows - 1.19.1 containing this change is available at https://epr.elastic.co/search?package=windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants