Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Zscaler ZPA] Add dynamic mapping and resolve issue related to ECS field #5409

Merged
merged 3 commits into from Mar 15, 2023

Conversation

ashaka-elastic
Copy link
Contributor

Type of change

  • Enhancement
  • Bug

What does this PR do?

  • Add dynamic mapping for Zscaler ZPA
  • Resolve issue related to event.created ECS field

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/zscaler_zpa directory.
  • Run the following command to run tests.

elastic-package test

Related issues

Screenshots

image (29)
image (28)
image (27)
image (26)

@ashaka-elastic ashaka-elastic requested a review from a team as a code owner February 28, 2023 10:53
@elasticmachine
Copy link

elasticmachine commented Feb 28, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-09T12:47:25.614+0000

  • Duration: 18 min 3 sec

Test stats 🧪

Test Results
Failed 0
Passed 30
Skipped 0
Total 30

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Feb 28, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (5/5) 💚
Classes 100.0% (5/5) 💚
Methods 100.0% (59/59) 💚
Lines 90.221% (1550/1718) 👎 -4.963
Conditionals 100.0% (0/0) 💚

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment. LGTM 👍🏼
Thanks!

value: '{{{json.PublicIP}}}'
if: ctx?.json?.PublicIP != null
allow_duplicates: false
ignore_failure: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you avoid ignore_failure

@kcreddy kcreddy merged commit ce9bc67 into elastic:main Mar 15, 2023
1 check passed
@elasticmachine
Copy link

Package zscaler_zpa - 1.5.1 containing this change is available at https://epr.elastic.co/search?package=zscaler_zpa

agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 20, 2023
…eld (elastic#5409)

* Add dynamic mapping and resolve issue related to ECS field

* Update changelog entry

* Update manifest file
agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 21, 2023
…eld (elastic#5409)

* Add dynamic mapping and resolve issue related to ECS field

* Update changelog entry

* Update manifest file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Zscaler Private Access] Issue mapping event.created in audit logs
4 participants