Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AWS] Migrate NATGateway metrics visualizations to lenses #5426

Merged
merged 9 commits into from
Jun 7, 2023
Merged

[AWS] Migrate NATGateway metrics visualizations to lenses #5426

merged 9 commits into from
Jun 7, 2023

Conversation

gpop63
Copy link
Contributor

@gpop63 gpop63 commented Mar 1, 2023

What does this PR do?

Migrates visualizations to lenses and adds input control groups.

Before:
natgateway_before

After:
natgateway_after

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@gpop63 gpop63 changed the title [AWS] Migrate NATGateway visualizations to lenses [AWS] Migrate NATGateway metrics visualizations to lenses Mar 1, 2023
@gpop63 gpop63 force-pushed the migrate_aws-natgateway_vis-to-lens branch from 680beda to 4e2e5ad Compare March 1, 2023 22:40
@elasticmachine
Copy link

elasticmachine commented Mar 1, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-07T22:21:18.613+0000

  • Duration: 54 min 55 sec

Test stats 🧪

Test Results
Failed 0
Passed 190
Skipped 4
Total 194

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Mar 1, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (15/15) 💚
Files 93.75% (15/16) 👎 -3.125
Classes 93.75% (15/16) 👎 -3.125
Methods 85.921% (238/277) 👎 -3.121
Lines 85.925% (7387/8597) 👎 -2.31
Conditionals 100.0% (0/0) 💚

@gpop63 gpop63 force-pushed the migrate_aws-natgateway_vis-to-lens branch from 4e2e5ad to 7471846 Compare March 8, 2023 13:02
@gpop63 gpop63 marked this pull request as ready for review March 21, 2023 16:23
@gpop63 gpop63 requested review from a team as code owners March 21, 2023 16:23
@gpop63 gpop63 added Team:Cloud-Monitoring Label for the Cloud Monitoring team Integration:aws AWS labels Mar 22, 2023
drewdaemon
drewdaemon reviewed Apr 5, 2023
View reviewed changes
Copy link
Contributor

@drewdaemon drewdaemon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! One request: let's avoid using the Legacy Metric in favor of the Metric chart.

@botelastic
Copy link

botelastic bot commented May 5, 2023

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label May 5, 2023
@botelastic botelastic bot removed the Stalled label May 14, 2023
@gpop63
Copy link
Contributor Author

gpop63 commented May 14, 2023

I replaced legacy metrics charts with metrics charts.

Here's how it looks now:

natgateway_metrics

@drewdaemon
Copy link
Contributor

From meeting

  • can try stacking all three metrics in a single column
  • increase width and height of Action Connection Count bar chart

@gpop63 gpop63 self-assigned this May 22, 2023
@gpop63
Copy link
Contributor Author

gpop63 commented May 29, 2023

@drewdaemon what do you think about the width of the metric charts?

natgateway_new_layout

@drewdaemon
Copy link
Contributor

Looks good to me! @gvnmagni WDYT ^^

@gvnmagni
Copy link

Absolutely! 👍

@gpop63 gpop63 merged commit ba9f302 into elastic:main Jun 7, 2023
1 check passed
@elasticmachine
Copy link

Package aws - 1.41.0 containing this change is available at https://epr.elastic.co/search?package=aws

sodhikirti07 pushed a commit that referenced this pull request Jun 15, 2023
@gpop63 @sodhikirti07
[AWS] Migrate NATGateway metrics visualizations to lenses (#5426)
531edc6 
* add lenses and input control groups

* bump package version

* replace legacy with metric charts

* fix layout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmoog zmoog zmoog approved these changes

@drewdaemon drewdaemon drewdaemon approved these changes

Assignees

@gpop63 gpop63

Labels
Integration:aws AWS Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gpop63 @elasticmachine @drewdaemon @gvnmagni @zmoog