-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tines: make email address optional and add note #5441
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
bug
Something isn't working
Team:Security-External Integrations
Integration:tines
Tines
labels
Mar 6, 2023
🌐 Coverage report
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
bhapas
approved these changes
Mar 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Package tines - 0.0.3 containing this change is available at https://epr.elastic.co/search?package=tines |
agithomas
pushed a commit
to agithomas/integrations
that referenced
this pull request
Mar 20, 2023
agithomas
pushed a commit
to agithomas/integrations
that referenced
this pull request
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes the email address configuration field optional; v13+ of self-hosted instances and all cloud instances do not require it and so it would be confusing. Do leave it though since there may be pre v13 users, but add a note with a link to the Tines auth documentation.
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots