Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tines: make email address optional and add note #5441

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Mar 6, 2023

What does this PR do?

Makes the email address configuration field optional; v13+ of self-hosted instances and all cloud instances do not require it and so it would be confusing. Do leave it though since there may be pre v13 users, but add a note with a link to the Tines auth documentation.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Screenshot 2023-03-06 at 15 50 23

@efd6 efd6 self-assigned this Mar 6, 2023
@elasticmachine
Copy link

elasticmachine commented Mar 6, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-06T22:25:32.428+0000

  • Duration: 15 min 3 sec

Test stats 🧪

Test Results
Failed 0
Passed 12
Skipped 0
Total 12

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Mar 6, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 91.304% (21/23) 👍 66.304
Lines 82.474% (160/194) 👎 -17.526
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review March 6, 2023 06:12
@efd6 efd6 requested a review from a team as a code owner March 6, 2023 06:12
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Contributor

@bhapas bhapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/tines/changelog.yml Outdated Show resolved Hide resolved
@efd6 efd6 merged commit 96e8c05 into elastic:main Mar 6, 2023
@elasticmachine
Copy link

Package tines - 0.0.3 containing this change is available at https://epr.elastic.co/search?package=tines

agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 20, 2023
agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Integration:tines Tines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tines] Remove email account field
3 participants