Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

okta: allow configuration of http keep-alives #5487

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Mar 9, 2023

What does this PR do?

Allows configuration of HTTP keep-alives. The default used departs from the current behaviour (disabled) to ensure the best experience for most cases by allowing connection reuse, but can be reverted to the old behaviour if needed.

It is an advanced configuation option since it's expected to not be needed in the vast majority of cases.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented Mar 9, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-09T01:21:14.719+0000

  • Duration: 14 min 2 sec

Test stats 🧪

Test Results
Failed 0
Passed 7
Skipped 0
Total 7

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Mar 9, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (19/19) 💚 9.091
Lines 87.864% (543/618) 👎 -4.929
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review March 9, 2023 01:23
@efd6 efd6 requested a review from a team as a code owner March 9, 2023 01:23
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 merged commit 581d4d4 into elastic:main Mar 9, 2023
@elasticmachine
Copy link

Package okta - 1.16.0 containing this change is available at https://epr.elastic.co/search?package=okta

andrewkroh added a commit to andrewkroh/integrations that referenced this pull request Mar 13, 2023
agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 20, 2023
agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:Okta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

okta: add configuration options to allow users to make use of httpjson keep-alive options
3 participants