Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netflow: enrich network direction and type #5500

Merged
merged 1 commit into from Mar 20, 2023
Merged

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Mar 10, 2023

What does this PR do?

Adds enrich network direction and type.

New test events are from the netflow9_e10s_4_7byte_pad.pcap and ipfix_test_procera_*52935.dat files in the netflow tests from elastic/beats@b6aa375 with adjustment for integration package testing.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented Mar 10, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-10T06:38:20.899+0000

  • Duration: 13 min 30 sec

Test stats 🧪

Test Results
Failed 0
Passed 14
Skipped 0
Total 14

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

New test events are from the netflow9_e10s_4_7byte_pad.pcap and ipfix_test_procera_*52935.dat
files in the netflow tests from elastic/beats@b6aa375
with adjustment for integration package testing.
@elasticmachine
Copy link

elasticmachine commented Mar 10, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 3.427
Classes 100.0% (1/1) 💚 3.427
Methods 100.0% (8/8) 💚 8.754
Lines 90.909% (80/88) 👎 -0.477
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review March 10, 2023 07:01
@efd6 efd6 requested a review from a team as a code owner March 10, 2023 07:01
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 merged commit 500d6c8 into elastic:main Mar 20, 2023
1 check passed
@elasticmachine
Copy link

Package netflow - 2.5.0 containing this change is available at https://epr.elastic.co/search?package=netflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Netflow ingest pipeline doesn't set network.type or network.direction fields
3 participants