Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fortinet_fortigate] Add ECS fields #5523

Merged
merged 14 commits into from
Mar 27, 2023
Merged

[fortinet_fortigate] Add ECS fields #5523

merged 14 commits into from
Mar 27, 2023

Conversation

LaZyDK
Copy link
Contributor

@LaZyDK LaZyDK commented Mar 13, 2023

What does this PR do?

Add user.name, host.name and dns.question.registered_domain fields.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@LaZyDK LaZyDK requested a review from a team as a code owner March 13, 2023 14:46
@elasticmachine
Copy link

elasticmachine commented Mar 13, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-27T00:15:36.981+0000

  • Duration: 16 min 50 sec

Test stats 🧪

Test Results
Failed 0
Passed 9
Skipped 0
Total 9

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@efd6
Copy link
Contributor

efd6 commented Mar 13, 2023

/test

LaZyDK and others added 2 commits March 14, 2023 00:23
@LaZyDK @efd6
Update packages/fortinet_fortigate/data_stream/log/elasticsearch/inge…
57d1e0c 
…st_pipeline/default.yml

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
@LaZyDK @efd6
Update packages/fortinet_fortigate/data_stream/log/elasticsearch/inge…
3bc6dd9 
…st_pipeline/default.yml

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
@elasticmachine
Copy link

elasticmachine commented Mar 13, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (4/4) 💚 3.354
Classes 100.0% (4/4) 💚 3.354
Methods 100.0% (39/39) 💚 8.98
Lines 91.246% (1157/1268) 👎 -0.146
Conditionals 100.0% (0/0) 💚

@LaZyDK LaZyDK closed this Mar 17, 2023
@LaZyDK LaZyDK deleted the patch-4 branch March 17, 2023 10:27
@LaZyDK LaZyDK restored the patch-4 branch March 17, 2023 10:30
@LaZyDK
Copy link
Contributor Author

LaZyDK commented Mar 17, 2023

My mistake.

@LaZyDK LaZyDK reopened this Mar 17, 2023
@efd6
Copy link
Contributor

efd6 commented Mar 17, 2023

/test

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

efd6
efd6 reviewed Mar 20, 2023
View reviewed changes
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs an elastic-package build.

packages/fortinet_fortigate/changelog.yml Outdated Show resolved Hide resolved
@LaZyDK
Copy link
Contributor Author

LaZyDK commented Mar 21, 2023

Ready for review

@efd6
Copy link
Contributor

efd6 commented Mar 21, 2023

/test

@LaZyDK
Copy link
Contributor Author

LaZyDK commented Mar 23, 2023

should be good now

@efd6
Copy link
Contributor

efd6 commented Mar 27, 2023

/test

efd6
efd6 approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@efd6 efd6 merged commit c5445e2 into elastic:main Mar 27, 2023
@elasticmachine
Copy link

Package fortinet_fortigate - 1.9.0 containing this change is available at https://epr.elastic.co/search?package=fortinet_fortigate

@LaZyDK LaZyDK deleted the patch-4 branch March 27, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request Integration:Fortinet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LaZyDK @elasticmachine @efd6