Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system: remove duplicate windows dashboards #5525

Merged
merged 1 commit into from Mar 20, 2023
Merged

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Mar 14, 2023

What does this PR do?

This removes the older of each pair of duplicated "[System Windows Security]" dashboards.

The dashboards were imported together from beats where they co-existed after the second set's addition. The changes that added them to beats appear to have been:

Retained:

  • system-bae11b00-9bfc-11ea-87e4-49f31ec44891 - User Logons
  • system-71f720f0-ff18-11e9-8405-516218e3d268 - User Management Events
  • system-bb858830-f412-11e9-8405-516218e3d268 - Group Management Events
  • system-d401ef40-a7d5-11e9-a422-d144027429da - Failed and Blocked Accounts

Deleted:

  • system-035846a0-a249-11e9-a422-d144027429da - User Logons - Simple Metrics
  • system-8223bed0-b9e9-11e9-b6a2-c9b4015c4baf - User Management Events - Simple Metric
  • system-01c54730-fee6-11e9-8405-516218e3d268 - Group Management Events - Simple Metrics
  • system-f49f3170-9ffc-11ea-87e4-49f31ec44891 - Failed and Blocked Accounts - Simple Metrics

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented Mar 14, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-20T21:00:39.371+0000

  • Duration: 15 min 2 sec

Test stats 🧪

Test Results
Failed 0
Passed 145
Skipped 0
Total 145

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Mar 14, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (4/4) 💚 3.216
Classes 100.0% (4/4) 💚 3.216
Methods 60.759% (48/79) 👎 -30.328
Lines 99.535% (2780/2793) 👍 7.48
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review March 14, 2023 02:54
@efd6 efd6 requested review from a team as code owners March 14, 2023 02:54
@efd6 efd6 requested review from ycombinator and faec March 14, 2023 02:54
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

The dashboards were imported together from beats where they co-existed
after the second sets addition. The changes that added them to beats
appear to have been:

- elastic/beats#18775
- elastic/beats#15236
@efd6 efd6 merged commit f7ec174 into elastic:main Mar 20, 2023
1 check passed
@elasticmachine
Copy link

Package system - 1.25.2 containing this change is available at https://epr.elastic.co/search?package=system

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Integration:System
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants