Add support for user database names with special characters for trans…

[ritalwar]

• Enhancement

What does this PR do?

This PR will support mssql metrics for transaction log for userdbs with special characters.

Checklist

• I have reviewed tips for building integrations and this pull request is aligned with them.
• I have verified that all data streams collect metrics or logs.
• I have added an entry to my package's changelog.yml file.
• I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Add the mssql integration.
Enable transaction_log metrics.
Add database names with special characters.
Data should come to ES without error.

Related issues

• Closes MSSQL support user dbs names with special characters #5528

Screenshots

[elasticmachine]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2023-03-23T10:58:25.136+0000

• Duration: 16 min 42 sec

Test stats 🧪

Test	Results
Failed	0
Passed	19
Skipped	0
Total	19

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

[elasticmachine]

🌐 Coverage report

Name	Metrics % (covered/total)	Diff
Packages	100.0% (2/2)	💚
Files	100.0% (2/2)	💚
Classes	100.0% (2/2)	💚
Methods	93.333% (28/30)	👍
Lines	100.0% (1238/1238)	💚 2.959
Conditionals	100.0% (0/0)	💚

[Danouchka]

Please when can we expect this to be released ?
Thank you

[lalit-satapathy]

LGTM.

@muthu-mps , Please check once and it can be merged.

[muthu-mps]

Can we add a description on the supported database name formats ?

[ritalwar]

Can we add a description on the supported database name formats ?

I think there isn't anything we are limiting specifically in our integration for naming the databases, so ideally if mssql supports it, we should also be able to parse those names.
If in case there are any specific formats you think we should mention, please let me know.

[lalit-satapathy]

Can we add a description on the supported database name formats ?

I think there isn't anything we are limiting specifically in our integration for naming the databases, so ideally if mssql supports it, we should also be able to parse those names. If in case there are any specific formats you think we should mention, please let me know.

I think this PR should support all regular DB names and DB names with special character. Not sure, we need a specific documentation around it.

[muthu-mps]

Looks good!

[elasticmachine]

Package microsoft_sqlserver - 1.17.0 containing this change is available at https://epr.elastic.co/search?package=microsoft_sqlserver