Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve docs on how to use condition filters #5586

Merged
merged 2 commits into from
Mar 20, 2023

Conversation

gsantoro
Copy link
Contributor

@gsantoro gsantoro commented Mar 20, 2023

What does this PR do?

Improve docs on how to use condition filters for datastreams.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

How to test this PR locally

Related issues

Screenshots

@gsantoro gsantoro added documentation Improvements or additions to documentation enhancement New feature or request docs labels Mar 20, 2023
@gsantoro gsantoro requested a review from a team as a code owner March 20, 2023 13:31
@gsantoro gsantoro self-assigned this Mar 20, 2023
@gsantoro gsantoro requested review from gizas and devamanv March 20, 2023 13:31
@elasticmachine
Copy link

elasticmachine commented Mar 20, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-20T13:36:21.553+0000

  • Duration: 29 min 17 sec

Test stats 🧪

Test Results
Failed 0
Passed 144
Skipped 0
Total 144

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (3/3) 💚
Classes 100.0% (3/3) 💚
Methods 94.928% (131/138) 👍 1.594
Lines 97.472% (347/356) 👎 -2.528
Conditionals 100.0% (0/0) 💚

@gsantoro gsantoro merged commit bc1825e into elastic:main Mar 20, 2023
@gsantoro gsantoro deleted the feature/condition_docs branch March 20, 2023 15:23
@elasticmachine
Copy link

Package docker - 2.4.3 containing this change is available at https://epr.elastic.co/search?package=docker

@elasticmachine
Copy link

Package istio - 0.2.6 containing this change is available at https://epr.elastic.co/search?package=istio

@elasticmachine
Copy link

Package kubernetes - 1.32.2 containing this change is available at https://epr.elastic.co/search?package=kubernetes

@elasticmachine
Copy link

Package istio - 0.3.0 containing this change is available at https://epr.elastic.co/search?package=istio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants