Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O11y][Salesforce] Lens migration for visualizations to Kibana version 8.5.0 #5590

Merged

Conversation

harnish-elastic
Copy link
Contributor

  • Enhancement

What does this PR do?

  • Migrate visualizations to lens for Salesforce integration package

  • Statistics for Salesforce Lens migration:

Salesforce Dashboards Before Migration     After Migration    
  Maps Lens Visualization Maps Lens Visualization
[Logs Salesforce] Login Dashboard 1 9 1 1 10 0
[Logs Salesforce] Apex Dashboard 0 11 2 0 13 0
[Logs Salesforce] Logout Dashboard 1 4 1 1 5 0
[Logs Salesforce] Setup Audit Trail Dashboard 0 4 0 0 4 0
  2 28 4 2 32 0

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to lens.
  • I have updated screenshots of dashboard.
  • I have verified that data count are matching and panel aggregations are same as before.

Author's checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.5.0 itself.

Related issues

@harnish-elastic harnish-elastic marked this pull request as ready for review March 20, 2023 16:17
@harnish-elastic harnish-elastic requested a review from a team as a code owner March 20, 2023 16:17
@kush-elastic kush-elastic added enhancement New feature or request v8.5.0 Team:Service-Integrations Label for the Service Integrations team Integration:salesforce Salesforce labels Mar 20, 2023
@elasticmachine
Copy link

elasticmachine commented Mar 20, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-20T16:17:29.604+0000

  • Duration: 16 min 28 sec

Test stats 🧪

Test Results
Failed 0
Passed 24
Skipped 0
Total 24

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 100.0% (4/4) 💚
Classes 100.0% (4/4) 💚
Methods 100.0% (49/49) 💚 6.667
Lines 96.844% (982/1014) 👎 -3.156
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agithomas
Copy link
Contributor

Please complete the Peer review before the merge.

Copy link
Collaborator

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@harnish-elastic
Copy link
Contributor Author

Please complete the Peer review before the merge.

@agithomas Merging this PR since peer review is completed.

@kush-elastic
Copy link
Collaborator

@harnish-elastic Can you update the title for the PR? I think version should be 8.5.0 instead of 8.4.0.

@harnish-elastic harnish-elastic changed the title [O11y][Salesforce] Lens migration for visualizations to Kibana version 8.4.0 [O11y][Salesforce] Lens migration for visualizations to Kibana version 8.5.0 Mar 21, 2023
@kush-elastic kush-elastic merged commit 3d060e8 into elastic:main Mar 21, 2023
@elasticmachine
Copy link

Package salesforce - 0.5.0 containing this change is available at https://epr.elastic.co/search?package=salesforce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:salesforce Salesforce Team:Service-Integrations Label for the Service Integrations team v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants