Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elastic Agent] Update dashboard filters and adding agent.* fields #5618

Merged

Conversation

P1llus
Copy link
Member

@P1llus P1llus commented Mar 21, 2023

What does this PR do?

  1. Adds field mapping definitions for agent.* fields that are missing from most datastreams, since dynamic: false we are unable to filter/search/aggregate on them properly without it.

  2. Filtered out APM on certain charts, as they also use agent.name

  3. Added elastic_agent* as a datastream filter for certain charts, and to filter out that datastream from others. This way we do not count our internal metrics/logging datastreams as "integrations", making them clutter the UI.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@P1llus P1llus added enhancement New feature or request Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team labels Mar 21, 2023
@P1llus P1llus requested a review from a team as a code owner March 21, 2023 15:38
@elasticmachine
Copy link

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@elasticmachine
Copy link

elasticmachine commented Mar 21, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-23T16:02:58.777+0000

  • Duration: 14 min 37 sec

Test stats 🧪

Test Results
Failed 0
Passed 31
Skipped 0
Total 31

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Mar 21, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 33.333% (25/75) 👎 -66.667
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@joshdover joshdover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on the description only, have not tested locally

@P1llus P1llus added Team:Elastic-Agent Label for the Agent team and removed Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team labels Mar 23, 2023
@P1llus P1llus merged commit cb03d17 into elastic:main Mar 24, 2023
@elasticmachine
Copy link

Package elastic_agent - 1.7.0 containing this change is available at https://epr.elastic.co/search?package=elastic_agent

@elasticmachine
Copy link

Package elastic_agent - 1.8.0 containing this change is available at https://epr.elastic.co/search?package=elastic_agent

@elasticmachine
Copy link

Package elastic_agent - 1.10.1 containing this change is available at https://epr.elastic.co/search?package=elastic_agent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants