Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCP] Support additional input param in PubSub input for all datastreams #5630

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

kcreddy
Copy link
Contributor

@kcreddy kcreddy commented Mar 22, 2023

What does this PR do?

Adds support for configuring subscription_num_goroutines and subscription_max_outstanding_messages parameters across all datastreams having GCP PubSub input.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Related issues

Screenshots

@kcreddy kcreddy added enhancement New feature or request Integration:GCP labels Mar 22, 2023
@kcreddy kcreddy self-assigned this Mar 22, 2023
@elasticmachine
Copy link

elasticmachine commented Mar 22, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-22T07:37:59.497+0000

  • Duration: 17 min 25 sec

Test stats 🧪

Test Results
Failed 0
Passed 57
Skipped 0
Total 57

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (6/6) 💚
Files 100.0% (6/6) 💚
Classes 100.0% (6/6) 💚
Methods 90.291% (93/103) 👎 -9.709
Lines 96.0% (1464/1525) 👎 -4.0
Conditionals 100.0% (0/0) 💚

@kcreddy kcreddy marked this pull request as ready for review March 22, 2023 08:10
@kcreddy kcreddy requested review from a team as code owners March 22, 2023 08:10
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@kcreddy kcreddy merged commit 0d524b9 into elastic:main Mar 22, 2023
@elasticmachine
Copy link

Package gcp - 2.18.0 containing this change is available at https://epr.elastic.co/search?package=gcp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:GCP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GCP] | Support num_goroutines and max_outstanding_messages for GCP PubSub datastreams
4 participants