Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O11y][Apache] Migrate Metrics overview dashboard visualizations to lens in kibana 8.3.0 #5636

Merged

Conversation

harnish-elastic
Copy link
Contributor

@harnish-elastic harnish-elastic commented Mar 22, 2023

  • Enhancement

What does this PR do?

  • Migrate visualizations to lens for Apache integration package

  • As per discussion with @SubhrataK,

    • For Total accesses, Kept the original value (not the k) in this case, as the number of accesses has to be the exact value and not a rounded off version.
  • Statistics for Apache Lens migration:

Apache Dashboards Before Migration     After Migration    
  Maps Lens Visualization Maps Lens Visualization
[Metrics Apache] Overview 0 0 12 0 11 1

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to lens.
  • I have updated screenshots of dashboard.
  • I have verified that data count are matching and panel aggregations are same as before.

Author's checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.3.0 itself.

Related issues

Issues Identified

Note:

  • Please refer the following before migrated screenshot for [Metrics Apache] Overview dashboard, because the current screenshot is not updated.

image

@kush-elastic kush-elastic added enhancement New feature or request Integration:apache Apache HTTP Server v8.3.0 Team:Service-Integrations Label for the Service Integrations team labels Mar 22, 2023
@harnish-elastic harnish-elastic marked this pull request as ready for review March 22, 2023 13:17
@harnish-elastic harnish-elastic requested a review from a team as a code owner March 22, 2023 13:17
@elasticmachine
Copy link

elasticmachine commented Mar 22, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-10T09:18:13.199+0000

  • Duration: 15 min 20 sec

Test stats 🧪

Test Results
Failed 0
Passed 32
Skipped 0
Total 32

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@kush-elastic
Copy link
Collaborator

/test

@harnish-elastic harnish-elastic marked this pull request as draft March 22, 2023 13:39
@harnish-elastic harnish-elastic marked this pull request as ready for review March 22, 2023 13:48
@elasticmachine
Copy link

elasticmachine commented Mar 22, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 50.0% (2/4) 👎 -50.0
Classes 50.0% (2/4) 👎 -50.0
Methods 70.0% (28/40) 👎 -30.0
Lines 70.234% (210/299) 👎 -18.896
Conditionals 100.0% (0/0) 💚

…into lens_migration-apache-metrics-8.3.0

Conflicts:
	packages/apache/changelog.yml
	packages/apache/kibana/visualization/apache-22057f20-3a12-11eb-8946-296aab7b13db.json
	packages/apache/kibana/visualization/apache-47820ce0-3a1d-11eb-8946-296aab7b13db.json
	packages/apache/kibana/visualization/apache-99666080-3a20-11eb-8946-296aab7b13db.json
	packages/apache/manifest.yml
@harnish-elastic
Copy link
Contributor Author

As discussed with @SubhrataK,

  1. For the Not able to convert value into human readable format ( Seconds / Minutes / Hours ), we keep the old visualization as it is due to not having functionality to user to convert into human-readable and also create the separate issue for the same to track in down.

  2. For the issue Not having feature to set last bucket value, we are good with the metrics chart. For the line/area chart we need auto functionality in reduced timerange. So for the time series visualization we still need to discuss with the kibana team.

  3. For the Splitting a chart into multiple smaller charts by a breakdown dimension is not supported in the lens, we are going to migrate into table chart. Also need to re-arrange the dashboard like first metrics, then line/area/bar charts, and the table charts be at last.

@harnish-elastic
Copy link
Contributor Author

@agithomas Updated the PR based on this comment. Thanks!

@harnish-elastic harnish-elastic requested a review from a team April 5, 2023 10:09
@harnish-elastic harnish-elastic requested review from a team as code owners April 5, 2023 10:09
@harnish-elastic harnish-elastic force-pushed the lens_migration-apache-metrics-8.3.0 branch from 7abe485 to 8777ad0 Compare April 5, 2023 10:47
@kush-elastic kush-elastic removed request for a team April 5, 2023 10:48
Copy link
Collaborator

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agithomas
Copy link
Contributor

@SubhrataK , can you please confirm if the new way of representation is good ? Please refer the screenshot

@harnish-elastic
Copy link
Contributor Author

@agithomas The line split charts are basically splitting charts into 5 or 10 line charts as per provided field. We don't have any functionality to migrate this kind of chart in lens. Also as discuss with @SubhrataK, the splitting chart has poor readability. Hence we have converted to table chart in which user can see their actual values based on time interval. Please refer the screenshot for more information.

apache-image

@harnish-elastic
Copy link
Contributor Author

harnish-elastic commented Apr 6, 2023

As discuss with @SubhrataK, we are going to rename Load1/5/15 to Average server load. Also will change the position of column and rename it like load per 1 min, load per 5 min, load per 15 min.

image

@agithomas If you feel like there are many fields in the table feel free to suggest any fields that we can remove.

image

Field names that have used

image

@agithomas
Copy link
Contributor

As discuss with @SubhrataK, we are going to rename Load1/5/15 to Average server load. Also will change the position of column and rename it like load per 1 min, load per 5 min, load per 15 min.

image

@agithomas If you feel like there are many fields in the table feel free to suggest any fields that we can remove.

image

Field names that have used

image

My concern is mainly around representing the CPU usage in tabular manner, when a line graph could explain the trends much better.

@harnish-elastic
Copy link
Contributor Author

@SubhrataK / @agithomas We have converted the line split chart to lens line chart. Let me know if it looks good to you so that we can update the PR accordingly. Please refer this screenshot.

image
image

@agithomas
Copy link
Contributor

@SubhrataK / @agithomas We have converted the line split chart to lens line chart. Let me know if it looks good to you so that we can update the PR accordingly. Please refer this screenshot.

image image

This looks much better and user friendly. Hope you can update the screenshot.

@harnish-elastic
Copy link
Contributor Author

@agithomas Updated the PR with suggested changes. Thanks!

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kush-elastic kush-elastic merged commit 18d1598 into elastic:main Apr 11, 2023
@elasticmachine
Copy link

Package apache - 1.9.0 containing this change is available at https://epr.elastic.co/search?package=apache

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:apache Apache HTTP Server Team:Service-Integrations Label for the Service Integrations team v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants