Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AWS] Add Firewall metrics dashboard input control groups #5650

Merged
merged 8 commits into from Jun 7, 2023
Merged

[AWS] Add Firewall metrics dashboard input control groups #5650

merged 8 commits into from Jun 7, 2023

Conversation

gpop63
Copy link
Contributor

@gpop63 gpop63 commented Mar 22, 2023

What does this PR do?

Adds input control groups.

I'm not sure if the markdown visualization (first one from images) can be converted to a lens. Should it be left like that or removed?

Before:
firewall_before

After:
firewall_after

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@gpop63 gpop63 added Team:Cloud-Monitoring Label for the Cloud Monitoring team Integration:AWS labels Mar 22, 2023
@elasticmachine
Copy link

elasticmachine commented Mar 22, 2023 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-07T18:15:26.065+0000

  • Duration: 48 min 5 sec

Test stats 🧪

Test Results
Failed 0
Passed 190
Skipped 4
Total 194

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Mar 22, 2023 •
edited

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (15/15) 💚
Files 93.75% (15/16) 👎 -0.694
Classes 93.75% (15/16) 👎 -0.694
Methods 85.921% (238/277) 👎 -0.948
Lines 85.925% (7387/8597) 👎 -0.654
Conditionals 100.0% (0/0) 💚

@gpop63 gpop63 marked this pull request as ready for review March 23, 2023 00:41
@gpop63 gpop63 requested review from a team as code owners March 23, 2023 00:41
drewdaemon
drewdaemon reviewed Mar 27, 2023
View reviewed changes
Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason you chose to use the Lens legacy metric visualization? In the future, this will likely be removed in favor of the metric visualization.

@botelastic
Copy link

botelastic bot commented Apr 26, 2023

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Apr 26, 2023
@botelastic botelastic bot removed the Stalled label May 14, 2023
@gpop63
Copy link
Contributor Author

gpop63 commented May 14, 2023

Replaced legacy metric charts. This is how it looks now:

firewall_metric_chart

drewdaemon
drewdaemon approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gpop63 sorry about this—let's take these back to the legacy metric for now. The way this dashboard is set up, especially after removing the legacy dashboard controls from the layout, just leaves too much vertical room for the new metric to make much sense.

Approving so as not to hold you up.

@drewdaemon
Copy link
Contributor

From meeting

  • put metrics in 3 columns of two
  • increase size of markdown panel to half of page (check if these metrics get too small on smaller screen)
  • make metrics white

@gpop63 gpop63 self-assigned this May 22, 2023
@gpop63
Copy link
Contributor Author

gpop63 commented May 29, 2023

@drewdaemon what do you think about the new layout?

firewall_new_layout

drewdaemon
drewdaemon approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gpop63 gpop63 merged commit b0773a1 into elastic:main Jun 7, 2023
3 checks passed
@elasticmachine
Copy link

Package aws - 1.40.7 containing this change is available at https://epr.elastic.co/search?package=aws

sodhikirti07 pushed a commit that referenced this pull request Jun 15, 2023
@gpop63 @sodhikirti07
[AWS] Add Firewall metrics dashboard input control groups (#5650)
d1fc6aa 
* add input control groups

* bump package version

* replace legacy with metric charts

* fix data stream filter

* fix layout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmoog zmoog zmoog approved these changes

@drewdaemon drewdaemon drewdaemon approved these changes

Assignees

@gpop63 gpop63

Labels
Integration:AWS Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gpop63 @elasticmachine @drewdaemon @zmoog