Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RabbitMQ] Added dimension fields for rabbitmq queue datastream #5660

Merged
merged 7 commits into from
Apr 3, 2023

Conversation

ritalwar
Copy link
Contributor

@ritalwar ritalwar commented Mar 23, 2023

  • Enhancement

What does this PR do?

This PR adds dimension fields for rabbitmq queue datastream to support TSDB.

Checklist

@elasticmachine
Copy link

elasticmachine commented Mar 23, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-03T15:41:42.934+0000

  • Duration: 14 min 30 sec

Test stats 🧪

Test Results
Failed 0
Passed 12
Skipped 0
Total 12

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Mar 23, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 70.0% (14/20) 👍
Lines 73.913% (34/46) 👍
Conditionals 100.0% (0/0) 💚

@ritalwar ritalwar mentioned this pull request Mar 24, 2023
21 tasks
@ritalwar ritalwar marked this pull request as ready for review March 24, 2023 05:50
@ritalwar ritalwar requested a review from a team as a code owner March 24, 2023 05:50
@ritalwar ritalwar changed the title Added dimension fields for rabbitmq queue datastream [RabbitMQ] Added dimension fields for rabbitmq queue datastream Mar 24, 2023
@@ -1,3 +1,8 @@
- version: "1.9.0"
changes:
- description: Added dimension fields for rabbitmq queue datastream to support TSDB.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the phrase rabbitmq

@@ -3,6 +3,7 @@
fields:
- name: name
type: keyword
dimension: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the reason

@agithomas
Copy link
Contributor

Please add a vhost name as dimension

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ritalwar ritalwar merged commit 4d1636c into elastic:main Apr 3, 2023
@elasticmachine
Copy link

Package rabbitmq - 1.8.3 containing this change is available at https://epr.elastic.co/search?package=rabbitmq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants