Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O11y][CockroachDB] Migrate visualizations to lens in Kibana 8.4.0 #5688

Merged

Conversation

rajvi-patel-22
Copy link
Contributor

@rajvi-patel-22 rajvi-patel-22 commented Mar 27, 2023

  • Enhancement

What does this PR do?

  • Migrate visualizations to lens for CockroachDB integration package

  • Statistics for CockroachDB Lens migration:

CockroachDB Dashboards Before Migration   After Migration  
  Lens Visualization Lens Visualization
[CockroachDB Metrics] Overview 0 7 7 0
  0 7 7 0

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to lens.
  • I have updated screenshots of dashboard.
  • I have verified that data count are matching and panel aggregations are same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.4.0 itself.

Related issues

Issues Identified

Note: The screenshot of the [CockroachDB Metrics] Overview dashboard is not synced with the Kibana files. Please refer to the below screenshot to compare the migrated visualization:
1663405757-screencapture-storage-0-kb-us-central1-gcp-cloud-es-io-9243-app-dashboards-2023-03-15-17_15_02

@rajvi-patel-22 rajvi-patel-22 requested a review from a team as a code owner March 27, 2023 03:48
@kush-elastic kush-elastic added enhancement New feature or request Integration:cockroachdb CockroachDB Metrics v8.4.0 Team:Service-Integrations Label for the Service Integrations team labels Mar 27, 2023
@elasticmachine
Copy link

elasticmachine commented Mar 27, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-27T03:49:01.294+0000

  • Duration: 15 min 25 sec

Test stats 🧪

Test Results
Failed 0
Passed 4
Skipped 0
Total 4

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 2.23
Classes 100.0% (0/0) 💚 2.23
Methods 75.0% (3/4) 👎 -18.247
Lines 100.0% (0/0) 💚 6.878
Conditionals 100.0% (0/0) 💚

@ritalwar ritalwar self-requested a review March 27, 2023 05:23
Copy link
Collaborator

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kush-elastic kush-elastic merged commit f7b4c80 into elastic:main Mar 30, 2023
@elasticmachine
Copy link

Package cockroachdb - 1.3.0 containing this change is available at https://epr.elastic.co/search?package=cockroachdb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:cockroachdb CockroachDB Metrics Team:Service-Integrations Label for the Service Integrations team v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants