Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update metric_type for the fields of connection datastream #5718

Merged
merged 7 commits into from
Apr 4, 2023
Merged

Update metric_type for the fields of connection datastream #5718

merged 7 commits into from
Apr 4, 2023

Conversation

ritalwar
Copy link
Contributor

@ritalwar ritalwar commented Mar 28, 2023 •
edited
Loading

  • Enhancement

What does this PR do?

This PR adds metric type for fields of connection data stream of rabbitmq.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@ritalwar ritalwar mentioned this pull request Mar 28, 2023
Closed
21 tasks
@elasticmachine
Copy link

elasticmachine commented Mar 28, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-04T05:16:20.924+0000

  • Duration: 13 min 9 sec

Test stats 🧪

Test Results
Failed 0
Passed 12
Skipped 0
Total 12

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Mar 28, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 3.298
Classes 100.0% (1/1) 💚 3.298
Methods 70.0% (14/20) 👎 -21.214
Lines 73.913% (34/46) 👎 -17.488
Conditionals 100.0% (0/0) 💚

@ritalwar ritalwar marked this pull request as ready for review March 29, 2023 03:20
@ritalwar ritalwar requested a review from a team as a code owner March 29, 2023 03:20
agithomas
agithomas reviewed Mar 30, 2023
View reviewed changes
packages/rabbitmq/docs/README.md Outdated
| rabbitmq.connection.packet_count.sent | Number of packets sent on the connection. | long | counter |
| rabbitmq.connection.peer.host | Peer hostname obtained via reverse DNS, or its IP address if reverse DNS failed or was not enabled. | keyword | |
| rabbitmq.connection.peer.port | Peer port. | long | |
| rabbitmq.connection.port | Server port. | long | gauge |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the metric_type mapping for Port

agithomas
agithomas approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ritalwar ritalwar merged commit 7c3b945 into elastic:main Apr 4, 2023
@elasticmachine
Copy link

Package rabbitmq - 1.8.4 containing this change is available at https://epr.elastic.co/search?package=rabbitmq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agithomas agithomas agithomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ritalwar @elasticmachine @agithomas