Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O11y][IIS] Migrate Website Overview dashboard visualizations to lens in kibana 8.5.0 #5726

Conversation

rajvi-patel-22
Copy link
Contributor

@rajvi-patel-22 rajvi-patel-22 commented Mar 29, 2023

  • Enhancement

What does this PR do?

  • Migrate visualizations to lens for IIS integration package

  • Statistics for IIS Lens migration:

IIS dashboard Before Migration   After Migration  
  Lens Visualization Lens Visualization
[Metrics IIS] Website Overview 0 15 14 1
  0 15 14 1

Note: 1 markdown panel has not been migrated because we don't have any alternatives in lens for markdown.
1-metricbeat-iis-application-pool-overview

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to lens.
  • I have updated screenshots of dashboard.
  • I have verified that data count are matching and panel aggregations are same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.5.0 itself.

Related issues

@rajvi-patel-22 rajvi-patel-22 requested a review from a team as a code owner March 29, 2023 05:20
@elasticmachine
Copy link

elasticmachine commented Mar 29, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-13T07:47:16.867+0000

  • Duration: 14 min 42 sec

Test stats 🧪

Test Results
Failed 0
Passed 29
Skipped 0
Total 29

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Mar 29, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 85.714% (30/35)
Lines 93.772% (271/289)
Conditionals 100.0% (0/0) 💚

@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Mar 29, 2023
9 tasks
@kush-elastic kush-elastic added enhancement New feature or request Integration:iis IIS v8.5.0 Team:Service-Integrations Label for the Service Integrations team labels Mar 29, 2023
@milan-elastic
Copy link
Contributor

Thanks, @rajvi-elastic ! Approved!

@agithomas
Copy link
Contributor

@SubhrataK , i am really not sure if Red colour is a good colour to choose service uptime, especially when service uptime value is really a high value. Can you suggest an appropriate theme or colour here?

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is something fundamentally wrong with Total Get Request , Total Post Request, Total Put Request, Total Delete Request title and the visualisation values shown in the graph.

If the field is capturing the Total value, the graph is expected to show an increasing trend.

If the field is capturing the value at a given time, then the title is wrong, it should not be Total. It must be Get Request / Sec. I do not think it is the case as there exist a dashboard already.

So, you may want to see the value that you are populating to generate the graph.

@rajvi-patel-22
Copy link
Contributor Author

I think there is something fundamentally wrong with Total Get Request , Total Post Request, Total Put Request, Total Delete Request title and the visualisation values shown in the graph.

If the field is capturing the Total value, the graph is expected to show an increasing trend.

If the field is capturing the value at a given time, then the title is wrong, it should not be Total. It must be Get Request / Sec. I do not think it is the case as there exist a dashboard already.

So, you may want to see the value that you are populating to generate the graph.

@agithomas, Updated the screenshot.

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agithomas
Copy link
Contributor

Please complete the peer review

@kush-elastic kush-elastic merged commit 709e3df into elastic:main Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:iis IIS Team:Service-Integrations Label for the Service Integrations team v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants