-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[O11y][Redis Enterprise] Add description for panels #5737
[O11y][Redis Enterprise] Add description for panels #5737
Conversation
🌐 Coverage report
|
@rajvi-elastic , In the comment, it was mentioned the option to add description is not available in version until 8.6. In the PR, i do not see a kibana version change. Can you re-check on this point and clarify? |
@rajvi-elastic , please link the PR to the redis enterprise migration issue for purpose of ease of tracking |
@agithomas, Do we really want to upgrade Kibana version for this change? Because this change will not cause any issue in older Kibana Version (For eg., |
I now see that there is no change in the kibana version and hence I am good. |
@SubhrataK , can you please help by discussing with @rajvi-elastic on the missing tool-tip issue , she highlighted and is it an important one and if it is Ok to loose the feature? |
@rajvi-elastic As discussed, as long as the panel names are meaningful and self explanatory, we can live without the tool tips . Anyhow, this feature is available in later versions of Kibana, so should not be a blocker. Also, please update the dashboards, with suggestions provided for changing the Titles of each of the panels, so that tool tips are not required. |
@agithomas, While updating labels in |
Approved! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Package redisenterprise - 0.4.1 containing this change is available at https://epr.elastic.co/search?package=redisenterprise |
What does this PR do?
8.7
.Checklist
changelog.yml
file.Author's Checklist
8.7.0
Related issues
Screenshots
Note: We identified that adding description at
embeddableConfig.attributes.description
rather than adding atembeddableConfig.description
will show tooltip in8.3.0
.