Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[integrations][tennable_io] - Updates package to corelate with latest httpjson change #5741

Merged
merged 2 commits into from Mar 31, 2023

Conversation

ShourieG
Copy link
Contributor

Type of change

  • Bug

What does this PR do?

This adds response.save_first_response parameter to httpjson yml.hbs files to support the latest change in the httpjson input with regards to how the first_response object is saved/accessed.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@ShourieG ShourieG requested a review from a team as a code owner March 30, 2023 09:29
@ShourieG ShourieG self-assigned this Mar 30, 2023
@ShourieG ShourieG changed the title [integrations][tennable_io] Updated package to corellate with latest httpjson change [integrations][tennable_io] - Updates package to corelate with latest httpjson change Mar 30, 2023
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Mar 30, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-30T09:31:13.015+0000

  • Duration: 16 min 7 sec

Test stats 🧪

Test Results
Failed 0
Passed 18
Skipped 0
Total 18

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Mar 30, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (3/3) 💚
Classes 100.0% (3/3) 💚
Methods 95.455% (42/44) 👍 26.224
Lines 91.798% (2104/2292) 👎 -8.202
Conditionals 100.0% (0/0) 💚

@ShourieG ShourieG merged commit c02072a into elastic:main Mar 31, 2023
1 check passed
@ShourieG ShourieG deleted the bugfix/tennable_io branch March 31, 2023 08:49
@elasticmachine
Copy link

Package tenable_io - 0.2.1 containing this change is available at https://epr.elastic.co/search?package=tenable_io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants